Skip to content

fix(BoxIcon): Replace BoxIcon with RhUiContainerFillIcon#12482

Merged
nicolethoen merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-box-icon-with-rh-ui-container-fill
Jun 17, 2026
Merged

fix(BoxIcon): Replace BoxIcon with RhUiContainerFillIcon#12482
nicolethoen merged 1 commit into
patternfly:mainfrom
rebeccaalpert:cursor/replace-box-icon-with-rh-ui-container-fill

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jun 16, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Part of #12401. Breaking into separate PRs so it is easier to review.

Made with Cursor and manually reviewed in site/checked output.

Summary by CodeRabbit

  • Documentation
    • Updated Alert and Tabs component examples to use a different icon in relevant demonstrations.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8c2dfb38-f5d9-42f5-bb73-d61d4f92e5db

📥 Commits

Reviewing files that changed from the base of the PR and between 256cd06 and d2c3204.

📒 Files selected for processing (5)
  • packages/react-core/src/components/Alert/examples/Alert.md
  • packages/react-core/src/components/Alert/examples/AlertCustomIcons.tsx
  • packages/react-core/src/components/Tabs/examples/Tabs.md
  • packages/react-core/src/components/Tabs/examples/TabsFilledWithIcons.tsx
  • packages/react-core/src/components/Tabs/examples/TabsIconAndText.tsx

Walkthrough

Replaces BoxIcon with RhUiContainerFillIcon across Alert and Tabs example files. The swap affects imports and render sites in AlertCustomIcons.tsx, TabsFilledWithIcons.tsx, and TabsIconAndText.tsx, with matching import-line updates in Alert.md and Tabs.md.

Changes

Icon replacement across Alert and Tabs examples

Layer / File(s) Summary
BoxIcon → RhUiContainerFillIcon in Alert and Tabs examples
packages/react-core/src/components/Alert/examples/Alert.md, packages/react-core/src/components/Alert/examples/AlertCustomIcons.tsx, packages/react-core/src/components/Tabs/examples/Tabs.md, packages/react-core/src/components/Tabs/examples/TabsFilledWithIcons.tsx, packages/react-core/src/components/Tabs/examples/TabsIconAndText.tsx		 BoxIcon import and usage is replaced with RhUiContainerFillIcon in the "info" alert custom icon and the "Containers" tab title icon across all affected example files and their documentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • thatblindgeye
  • nicolethoen
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing BoxIcon with RhUiContainerFillIcon across multiple example files and documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rebeccaalpert rebeccaalpert marked this pull request as draft June 16, 2026 20:29
@patternfly-build

patternfly-build commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-react-pr-12482.surge.sh

A11y report: https://pf-react-pr-12482-a11y.surge.sh

@rebeccaalpert rebeccaalpert marked this pull request as ready for review June 16, 2026 20:33
@rebeccaalpert rebeccaalpert mentioned this pull request Jun 17, 2026
Open
31 tasks
@nicolethoen

nicolethoen commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

needs a rebase

@rebeccaalpert @cursoragent
fix(BoxIcon): Replace BoxIcon with RhUiContainerFillIcon
d2c3204 
Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert rebeccaalpert force-pushed the cursor/replace-box-icon-with-rh-ui-container-fill branch from 0079ab9 to d2c3204 Compare June 17, 2026 18:10
@nicolethoen nicolethoen merged commit 5f07ec9 into patternfly:main Jun 17, 2026
23 of 24 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Jun 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolethoen nicolethoen nicolethoen approved these changes
@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rebeccaalpert @patternfly-build @nicolethoen @thatblindgeye